Skip to content

feat: Make CREATE EXTENSION tests optional #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mbiagetti wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: Make CREATE EXTENSION tests optional #92

mbiagetti wants to merge 7 commits into from
+157 −50

Conversation

@mbiagetti
Copy link
Contributor

@mbiagetti mbiagetti commented Jan 29, 2026 •
edited by mnencia
Loading

Adds a create_extension boolean field to extension metadata so that extensions providing only libraries or tools (e.g. wal2json) can skip CREATE EXTENSION tests. When create_extension is false, the extension is omitted entirely from the Database CR's extensions_spec and the status assertion skips the extensions field.

The generated database_assert_status map conditionally includes or excludes the extensions key, avoiding the Chainsaw limitation where extensions: null would require the field to exist in the actual resource. The psql verification job in check-extension.yaml also reads create_extension and skips when false.

Example generated values for create_extension: true (pgvector):

name: pgvector
sql_name: vector
shared_preload_libraries: []
pg_image: ghcr.io/cloudnative-pg/postgresql:18-minimal-trixie
version: 0.8.1
create_extension: true
extensions:
    - name: pgvector
      image:
        reference: registry.pg-extensions:5000/pgvector-testing:0.8.1-18-trixie
database_config:
    extensions_spec:
        - ensure: present
          name: vector
          version: 0.8.1
database_assert_status:
    applied: true
    observedGeneration: 1
    extensions:
        - applied: true
          name: vector

Example generated values for create_extension: false (wal2json):

name: wal2json
sql_name: wal2json
shared_preload_libraries: []
pg_image: ghcr.io/cloudnative-pg/postgresql:18-minimal-trixie
version: 2.6
create_extension: false
extensions:
    - name: wal2json
      image:
        reference: registry.pg-extensions:5000/wal2json-testing:2.6-18-trixie
database_config: {}
database_assert_status:
    applied: true
    observedGeneration: 1

Closes #85

@mbiagetti mbiagetti requested review from a team and NiccoloFei as code owners January 29, 2026 16:28
mbiagetti
mbiagetti commented Jan 29, 2026
View reviewed changes
@NiccoloFei NiccoloFei mentioned this pull request Feb 2, 2026
Merged
@NiccoloFei NiccoloFei force-pushed the mbiagetti/dev/85 branch 4 times, most recently from 60a3587 to 26b1448 Compare February 5, 2026 13:29
gbartolini
gbartolini reviewed Feb 9, 2026
View reviewed changes
@gbartolini
docs: add comment to metadata template
174d2c0 
Signed-off-by: Gabriele Bartolini <[email protected]>
@gbartolini
Copy link
Contributor

gbartolini commented Feb 11, 2026

I have tried this patch using an extension that doesn't need create extension like wal2json but I see that the tests are run anyway on the database.yaml file which still lists the extension:

apiVersion: postgresql.cnpg.io/v1
kind: Database
metadata:
  name: (join('-', [$values.name, 'app']))
spec:
  name: app
  owner: app
  cluster:
    name: ($values.name)
  extensions: ($values.database_config.extensions_spec)

In my opinion, this test should be skipped or, if we want to, we should use a template that adds the extensions option only if the create extension capability is provided by the extension.

@gbartolini gbartolini mentioned this pull request Feb 11, 2026
Closed
@mnencia
fix(testing-values): populate create_extension in testing values
688cb28 
TestingValues was missing the CreateExtension field, so the generated
values.yaml never contained create_extension, causing the psql
verification job to always skip.

Closes cloudnative-pg#85

Signed-off-by: Marco Nenciarini <[email protected]>
@mnencia
refactor(testing-values): eliminate redundant metadata parsing and re…
6a25361 
…gistry calls

Bundle extension metadata with its configuration so
generateDatabaseConfig no longer re-parses metadata or re-fetches
image annotations for each extension.

Signed-off-by: Marco Nenciarini <[email protected]>
@mnencia
chore(deps): sync dagger module after v0.19.11 upgrade
09da407 
Signed-off-by: Marco Nenciarini <[email protected]>
@mnencia
fix(testing): omit extensions from Database CR when create_extension
e0af6c6 
is false

Instead of listing extensions with ensure: absent in the Database CR,
skip them entirely from the extensions spec and expected status. This
avoids creating unnecessary extension entries in the Database CR for
library-only images like wal2json that don't provide a formal Postgres
extension object.

When all extensions have create_extension = false, both extensions_spec
and expected_status are omitted from the generated values, causing the
Database CR to have no extensions field and the assertion to expect no
extension status.

Signed-off-by: Marco Nenciarini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gbartolini gbartolini gbartolini left review comments

@mnencia mnencia mnencia approved these changes

@NiccoloFei NiccoloFei NiccoloFei approved these changes

+1 more reviewer

@GabriFedi97 GabriFedi97 GabriFedi97 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make CREATE EXTENSION tests optional

5 participants

@mbiagetti @gbartolini @mnencia @NiccoloFei @GabriFedi97